docs: follow up GP import doc coverage - #91
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a77b7e03ec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| numerator += dx * dy; | ||
| var_x += dx * dx; | ||
| var_y += dy * dy; | ||
| numerator = dx.mul_add(dy, numerator); |
There was a problem hiding this comment.
Preserve exact-tie key ordering
When a part's duration-weighted pitch-class histogram gives an exact tie between two rotated KK profiles, the documented tie-breaker is the first key scanned. The fused accumulation can split that exact tie by one ulp: for example histogram [194,498,821,804,875,237,243,964,12,952,316,475] makes D major and G major exact ties, but this line rounds D's numerator lower and estimate_harmony now picks G major, changing PartProfile::harmony and downstream complement pitch material for existing ambiguous parts. Either keep the previous accumulation or add an explicit epsilon/tie comparison so lint cleanup doesn't alter key ordering.
Useful? React with 👍 / 👎.
Motivation
Description
core/src/gp.rsincludinggp_song_to_score,build_gp_master_bars,build_gp_track,build_gp_voice,append_beat, andrest_groupto improve doc coverage.rotated_correlation(core/src/complement.rs) to usef64::mul_addfornumerator,var_x, andvar_y, addressing theclippy::suboptimal_flopsnursery lint.Testing
cargo fmt --all --checkwhich succeeded.cargo clippy --workspace --all-targets -- -D warningswhich succeeded with the nursery lint fixed.cargo test --workspacewhich completed with all tests passing.Codex Task