feat: import Guitar Pro tapping as a tapped note (#75)

[PhysShell]

Imports Guitar Pro's two-hand tapping as NoteMark::Tap, finishing #75's missing-technique-parsing asks (alongside let-ring; pull-off was re-scoped — it needs pitch-direction inference, not a field map).

What

• Tapping in GP is a beat-level effect (BeatEffects::slap_effect == Tapping), not a note effect — so append_beat resolves it once per beat and marks every note struck in the beat with NoteMark::Tap, exactly mirroring the existing dead-note flag (map_gp_note_marks only sees per-note effects, so it stays out of it).
• Slapping and popping (bass techniques) have no griff mark and are deliberately left unmapped (documented inline).
• Tapping flows into curation's free-form techniques list as "tap" — names-only, like accent/ghost. The passage-level TappingPassage tag is dominance-based and is deliberately not derived per-occurrence (technique.rs), so there's no new SwancoreTag and no SCHEMA_VERSION change.

NoteMark::Tap already existed in the model but no importer set it — this wires it up.

TDD

red (52191a6) → green (495031e).

Verification

• New tapping_beat_marks_every_note_as_tapped test (builds a tapped Beat, asserts the imported note bears NoteMark::Tap) + full workspace suite green
• cargo clippy --workspace --all-targets -- -D warnings clean
• cargo fmt --all --check clean

🤖 Generated with Claude Code

https://claude.ai/code/session_01TTUbGjzD8ysnVnCJnZJE95

---

Generated by Claude Code

Summary by CodeRabbit

• New Features

  • Added support for importing Guitar Pro beat-level tapping effects during file processing.

• Tests

  • Added unit test to verify tapping effects are correctly applied to imported notes.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c0607071-3b31-4ba8-8e1d-956b8395e906

📥 Commits

Reviewing files that changed from the base of the PR and between 8561a9e and 495031e.

📒 Files selected for processing (1)

• core/src/gp.rs

---

📝 Walkthrough

Walkthrough

In append_beat, a boolean is derived from beat.effect.slap_effect == SlapEffect::Tapping and used to insert NoteMark::Tap into each normal/dead note's marks set. A unit test constructs a tapping beat and asserts the resulting note carries NoteMark::Tap.

Changes

GP Beat Tapping → NoteMark::Tap

Layer / File(s)	Summary
Tapping detection, mark insertion, and test core/src/gp.rs	append_beat computes a is_tapping boolean from the beat's slap_effect field and conditionally inserts NoteMark::Tap into each normal/dead note's marks set. A new test constructs a beat with slap_effect = Tapping and asserts the imported note includes NoteMark::Tap.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

• PhysShell/griff#53: Modifies the same append_beat function in core/src/gp.rs for tie handling, directly adjacent to where the tapping flag is now computed.
• PhysShell/griff#69: derive_techniques in core/src/technique.rs reads NoteMark values to produce technique tags, so NoteMark::Tap emitted by this PR will now feed into that derivation pipeline.

Poem

🐇 Tap tap tap upon the string,
A beat effect, a new mark ring,
SlapEffect::Tapping caught with care,
NoteMark::Tap placed right in there,
The test confirms it, hip hooray—
The rabbit taps its feet today! 🎸

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: importing Guitar Pro tapping technique as a tapped note mark.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/modest-maxwell-0zecwn

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[PhysShell]

@codex brooo

[chatgpt-codex-connector]

Summary

• Added Rust doc comments for the Guitar Pro import conversion helpers, including song, master-bar, track, voice, beat, and rest-group construction, to address the doc coverage warning on the original PR. core/src/gp.rsL187-L192 core/src/gp.rsL236-L241 core/src/gp.rsL277-L282 core/src/gp.rsL330-L335 core/src/gp.rsL402-L407 core/src/gp.rsL535-L536
• Updated rotated-correlation floating-point accumulation to use f64::mul_add, resolving the Clippy nursery suboptimal_flops warning encountered during verification. core/src/complement.rsL591-L596
• Committed the changes on the current branch: a1e46ed docs(core): document GP import helpers.
• Created the follow-up PR with title: docs: follow up GP import doc coverage.

Testing

• ✅ cargo fmt --all --check
• ✅ cargo clippy --workspace --all-targets -- -D warnings
• ✅ cargo test --workspace

View task →