-
Notifications
You must be signed in to change notification settings - Fork 0
feat(core): parse GP let-ring into a LetRing technique + tag (#75, part 1) #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding
SwancoreTag::LetRingcreates a new serialized corpus tag value ("let_ring"), andall_variants()now exposes it to the CLI/web curation paths that writeChunkMeta.tags, butSCHEMA_VERSIONremains 7. A newly curated v7 manifest or chunk containing this tag is no longer readable by older v7 tooling because serde rejects unknown enum variants, so the version no longer identifies compatible corpus data; bump the schema version and document the tag-taxonomy change when adding this persisted enum value.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mechanism is right (serde rejects unknown variants), but we're deliberately keeping
SCHEMA_VERSION = 7— maintainer's call. Every version v1–v7 is a structuralChunkMetachange (a new optional field under the forward-compatible "pre-vN records keep loading" pattern); none tracks the tag set. ASwancoreTagaddition fits neither that mechanism nor that compat direction (yours is backward compat — old reader, new data), and #75 adds ~15 more tags, so versioning the taxonomy would turnSCHEMA_VERSIONinto a tag counter and muddy what it identifies.Made the policy explicit so it isn't ambiguous going forward (
333a3cc): a note in theSCHEMA_VERSIONdoc + a decisions-log Y-statement. The residual risk (a pinned pre-tag build hard-rejecting a chunk with a newer tag) is accepted — griff's reader and writer ship together.Generated by Claude Code