fix(web): checkbox groups for tags & quality in the capture panel - #68
Merged
Conversation
The tag and quality-flag pickers were native <select multiple> controls, which on desktop need Ctrl/Cmd-click to select more than one and silently wipe the whole selection on a plain click — confusing and easy to get wrong. Both become checkbox groups in a <fieldset>: #capTags is filled from the wasm tag palette as checkboxes, #capQuality holds the four static flags. selectedValues() now reads input[type=checkbox]:checked, still emitting the space-separated indices build_chunk_json/parse_indices expect — the emitted chunk.json is byte-identical to before. Static-asset-only change; host + wasm32 builds and the 16 web tests are unaffected. node --check passes on app.js. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TTUbGjzD8ysnVnCJnZJE95
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #67. Replaces the two native
<select multiple>pickers in the chunk-capture panel (tags, quality flags) with checkbox groups.<select multiple>is a known UX trap on desktop: you must Ctrl/Cmd-click to pick more than one, and a plain click silently wipes the whole selection. Checkboxes make multi-select obvious on both desktop and phone.How
#capTags/#capQualitybecome<div class="checkgrid">inside a<fieldset>; tags render as checkboxes from the wasm tag palette, quality holds the four static flags (cleanpre-checked).selectedValues()now readsinput[type="checkbox"]:checkedand still returns the same space-separated indicesbuild_chunk_json/parse_indicesexpect — the emittedchunk.jsonis byte-identical to before..checks/.checkgridCSS (responsive grid, 20px boxes, big touch targets); drops the now-deadselect[multiple]rules.Scope / tests
Static-asset-only (JS/HTML/CSS) — no Rust, no schema change. Host +
wasm32release builds and the 16 web tests are unaffected;node --checkpasses onapp.js.Reaches the live Pages site on merge to
main(web.yml).🤖 Generated with Claude Code
https://claude.ai/code/session_01TTUbGjzD8ysnVnCJnZJE95
Generated by Claude Code