Skip to content

docs(adr): accept ADR-0032 holdout filtering boundary - #167

Merged
PhysShell merged 1 commit into
mainfrom
claude/accept-adr-0032
Jul 29, 2026
Merged

docs(adr): accept ADR-0032 holdout filtering boundary#167
PhysShell merged 1 commit into
mainfrom
claude/accept-adr-0032

Conversation

@PhysShell

Copy link
Copy Markdown
Owner

ADR-0032 has completed independent review at exact head c44a89ccfc29fc9df42c58b5a48d469076db05a3 and was merged to main as 6f04c21400ead9e7350de480122c2957823ba29b.

The accepted contract fixes:

  • offline Reachability Lab ownership;
  • authoritative LoadedCorpus binding;
  • absence-capable corpus preparation;
  • distinct NoCorpus, LeakyDiagnostic, and HoldoutTargetSong semantics;
  • fail-closed song preflight and filtering before CorpusMaterial construction;
  • production generation and reranking remain untouched.

This PR changes status only (Proposed → Accepted in the ADR and its README index row). Implementation remains a separate RED→GREEN slice. No decisions.log.md change, no code, no wording change to the accepted contract.

🤖 Generated with Claude Code

https://claude.ai/code/session_012T7SRMiXmZe5v1imtrKMPi

Status: Proposed -> Accepted, per governance review. Status only — no
wording change to the accepted contract. Under ADR-0009 an Accepted ADR is
immutable; supersede it with a new one rather than editing.

Not appended to decisions.log.md (reserved for ADRs). Gates the song-mode
holdout-wiring implementation slice.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012T7SRMiXmZe5v1imtrKMPi
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@PhysShell, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 9 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 60a9a035-2037-4532-9b2c-0490ea9237c0

📥 Commits

Reviewing files that changed from the base of the PR and between 6f04c21 and 0c16104.

📒 Files selected for processing (2)
  • docs/adr/0032-holdout-filtering-boundary.md
  • docs/adr/README.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@PhysShell
PhysShell merged commit 5a6a0f1 into main Jul 29, 2026
15 checks passed
@PhysShell
PhysShell deleted the claude/accept-adr-0032 branch July 29, 2026 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant