Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenGraph etc fields not correctly populated if no Domain is specified in deployment #9

Closed
Phuurl opened this issue Apr 23, 2022 · 0 comments
Closed

OpenGraph etc fields not correctly populated if no Domain is specified in deployment #9

Phuurl opened this issue Apr 23, 2022 · 0 comments
Assignees
@Phuurl
Labels
bug Something isn't working

Comments

@Phuurl
Copy link
Owner

Phuurl commented Apr 23, 2022

On the example site:

<meta property="og:url" content="https:///39c66d7a-e793-412c-8209-33cb1ef63c7b/">
<meta property="og:image" content="https:///39c66d7a-e793-412c-8209-33cb1ef63c7b/39c66d7a-e793-412c-8209-33cb1ef63c7b.png">
<meta property="twitter:image" content="https:///39c66d7a-e793-412c-8209-33cb1ef63c7b/39c66d7a-e793-412c-8209-33cb1ef63c7b.png">
@Phuurl Phuurl self-assigned this Apr 23, 2022
@Phuurl Phuurl changed the title OpenGrapg etc fields not correctly populated if no Domain is specified in deployment OpenGraph etc fields not correctly populated if no Domain is specified in deployment Apr 23, 2022
@Phuurl Phuurl added the bug Something isn't working label Apr 23, 2022
@Phuurl Phuurl mentioned this issue Apr 24, 2022
Merged
@Phuurl Phuurl closed this as completed Apr 24, 2022
Phuurl added a commit that referenced this issue Apr 24, 2022
@Phuurl
Updates README to new example
d4e8335 
Redeployed after closing #9
Phuurl added a commit that referenced this issue Apr 29, 2022
@Phuurl
Initial release (#11)
eec1098 
* Initial upload

* README parameters and repo cleanup

* Adds Actions CI workflows (#1)

* Adds Actions CI workflows

* Corrects Go workflows

* Cleans up unrequired comments

* Adds some unit tests (#2)

* Adds some unit tests

* Excludes Gosec variable path check

As not relevant for execution environment

* Adds initial PR deploy workflow (#3)

* Adds initial PR deploy workflow

* Corrects if event statement

* Updates `sed` syntax to GNU version

* You must construct additional `\`s

* Switches to non-container build

* Updates tags and adds test input image

* Corrects CF output query strings

* Corrects output query quotes again

* Adds naming for CloudFront redirect Function

* Applies consistent `PR` capitalisation

* Adds PR cleanup workflow (#4)

* Adds PR cleanup workflow

* Adds `CloudFrontCachePolicyName`

* Corrects cleanup workflow (#5)

* Adds required SAM stack args (#6)

* Removes unsupported `--role-arn` from SAM destroy (#7)

* Removes `sam delete` confirmation requirement (#8)

* Adds invalid arg exit to Python script

* README diagram improvements

* Adds new stack parameters to README

* Adds additions README info

* Adds OpenGraph note

* Passes CloudFront domain to function when `NoDomain` is set (#10)

* Passes CloudFront domain to function

When NoDomain is set

* Adds repo name tag and JPEG upload to PR deploy

* Adds license

* Adds ACM region note to parameters

* Updates README to new example

Redeployed after closing #9

* Removed redundant tag

* Updates tests with `http-equiv` tag removal

* Adds Slack notification for PR deployment

* Corrects Slack payload

* Corrects Slack payload again

* Adds repo info to Slack notification

* Adds emoji to Slack message

* Whoops

* Adds cleanup workflow notification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Phuurl Phuurl

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Phuurl