Skip to content

Conversation

SmiVan
Copy link

@SmiVan SmiVan commented Jul 12, 2024

Current rockspec does not work with Luarocks because there is no "v0.8.1" tag in the repository.

To fix this either replace the tag specified in the rockspec (this PR does this), or add a "v0.8.1" tag to the repository to retrospectively make the rockspec correct.


Side note:

I think you may be misunderstanding how versioning works in luarocks, the - is supposed to separate the version of the package from the revision of the rockspec itself (see version in https://github.com/luarocks/luarocks/wiki/Rockspec-format#package-metadata).

So say if you're preparing to release v0.8.1 of your library - the rockspec version should read 0.8.1-1 as its the 1st revision of the rockspec file for the package version 0.8.1.

By the same logic rockspec version 0.8-1 should correspond to the 1st rockspec file revision of package version 0.8 - so should probably use the tag v0.8.

@vadi2
Copy link
Contributor

vadi2 commented Jan 4, 2025

Any change this could this be merged? As it stands you can't install the slaxml rock right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants