-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python test harness for openCVHelp class #1557
Merged
mcm001
merged 8 commits into
PhotonVision:master
from
thedropbears:tdb/add_opencvhelp_tests
Nov 14, 2024
Merged
Add Python test harness for openCVHelp class #1557
mcm001
merged 8 commits into
PhotonVision:master
from
thedropbears:tdb/add_opencvhelp_tests
Nov 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2d15526
to
e7c419e
Compare
14 tasks
b25aa18
to
d4c1092
Compare
fb9b586
to
0830bad
Compare
@mcm001 This is in a position that I am happy with for the time being. It still has stuff commented out, but that exercises an entire side of this lib that doesn't exist in Python atm. |
mcm001
approved these changes
Nov 14, 2024
mcm001
pushed a commit
that referenced
this pull request
Nov 14, 2024
What it says on the tin. This is all stuff from our initial effort to port the sim things. Right now it is coupled to #1557 because this fixes things up in that. Lets merge that one before dealing with this one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of this is still commented out because things are missing from the API. I will fill it in before marking this ready for review.
I will work on this more when #1548 and #1555 are merged because proper type checking and return types will make this easier to deal with