Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python test harness for openCVHelp class #1557

Merged
merged 8 commits into from
Nov 14, 2024

Conversation

LucienMorey
Copy link
Contributor

A bunch of this is still commented out because things are missing from the API. I will fill it in before marking this ready for review.

I will work on this more when #1548 and #1555 are merged because proper type checking and return types will make this easier to deal with

@LucienMorey LucienMorey requested a review from a team as a code owner November 11, 2024 11:25
@LucienMorey LucienMorey force-pushed the tdb/add_opencvhelp_tests branch 2 times, most recently from 2d15526 to e7c419e Compare November 12, 2024 22:39
@LucienMorey LucienMorey marked this pull request as draft November 12, 2024 23:38
@james-ward james-ward force-pushed the tdb/add_opencvhelp_tests branch from b25aa18 to d4c1092 Compare November 13, 2024 22:13
@james-ward james-ward force-pushed the tdb/add_opencvhelp_tests branch from fb9b586 to 0830bad Compare November 14, 2024 08:29
@LucienMorey LucienMorey marked this pull request as ready for review November 14, 2024 09:32
@LucienMorey
Copy link
Contributor Author

@mcm001 This is in a position that I am happy with for the time being. It still has stuff commented out, but that exercises an entire side of this lib that doesn't exist in Python atm.

@mcm001 mcm001 merged commit c50c657 into PhotonVision:master Nov 14, 2024
34 of 35 checks passed
mcm001 pushed a commit that referenced this pull request Nov 14, 2024
What it says on the tin. This is all stuff from our initial effort to
port the sim things. Right now it is coupled to #1557 because this fixes
things up in that. Lets merge that one before dealing with this one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants