Add Dockerfiles #48
Merged
Add Dockerfiles #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DockerfileLight assumes that yarn build has already been run. The dockerfile copies the contents of dist into an nginx alpine container. DockerfileFull assumes that yarn has not been built, and will build and deploy the application. The dockerfile is based on nginx:stable-alpine. The dockerfile first installs nodejs and yarn. After this, it copies the application into a folder. Then, it runs yarn and yarn build. Lastly, it copies the newly created contents of dist into the nginx folder.
Added dockerfile explanation and build/deploy commands.
Removed EXPOSE as port 80 is already exposed in base image
PhlexPlexico
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds 2 new files, DockerfileLight and DockerfileFull. This change also adds documentation to README.md for instructions on how to build and run the application in a docker container using the Dockerfile.
The dockerfiles base image is nginx:alpine-stable.
The DockerfileLight does not add any extra packages on top of nginx:alpine-stable.
It takes the completed dist files and adds them into the nginx directory.
The DockerfileFull adds nodejs and yarn to the nginx:alpine-stable image.
It takes the entire application, builds it using yarn, then copies the completed dist files and adds them to the nginx directory.
This allows someone without yarn installed to deploy the docker container.