-
Notifications
You must be signed in to change notification settings - Fork 361
Implement web/mac/windows/linux support #544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@remonh87 project is building fine for me in Android +Ios+Web , not sure why these checks are failing FlutterReactiveBle ble = FlutterReactiveBle( |
|
@rohitsangwan01 we would prefer if you use a separate package and publish it yourself :) . We of course can add your package to the readme. @Taym95 what do you think? |
|
@remonh87 yes but my current project is totally based on flutter_reactive_ble , and now i have to add other platforms support as well , so i wanted a way somehow , add support for different platforms without touching code , as Android/Ios is already stable ,and this web and Desktop (Windows + mac+linux) extensions i added to this package are already available in other packages |
Totally agree with @remonh87, we want to keep this repo for IOS/Android, and we are open to endorsing plugins for other platforms. |
|
@rohitsangwan01 When you have the repo setup do you mind posting it here? I'd love to incorporate into my project. |
|
@FXschwartz ,Sure , for now you can try out web version by downloading my fork , and add in your project locally , am still implementing this in my project , so might change few things later , for me , everything is working on Web , same as Mobile for now , also read Docs of reactive_ble_web before using that, there are some changes required in project to add web support |
|
Just a random passerby but I think it makes sense for flutter packages to not separate out platforms. Flutter itself is trying to be very cross platform by targeting most anything (whether this is good or bad) so I don't think it would be unusual to include web/mac etc. A table of platform features and yet-to-be-implemented's in the Readme is usually how I've seen other packages go about similar situations. |
|
I will close this one and looking forward for endorsing your package. |
I mean cross-platform is the whole point of Flutter. |
|
@nobodyguy yes and thats why we moved to federated plugin structure so other people of the community can step up and make a plugin for a platform based on ours. The problem is that with incorporating a new platform we increase the maintenance load with at least 33% per platform. We all do this in our free time and already struggle to answer all issues in this repo. |
Web Support with almost all Functionalities working , need some improvements though
Unimplemented Methods :
clearGattCache
requestMtuSize
requestConnectionPriority
Here is a demo of example app running without any changes ( just added web folder)
2022-03-30.01-19-12.mp4