Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recognize '---' as meta data fence #277

Merged
merged 3 commits into from
Mar 19, 2016

Conversation

Schlaefer
Copy link
Member

--- is used by some markup parsers as meta-data fence (e.g. Jekyll) and should be supported by Phile.

This PR replaces the existing hardcoded <!-- and /* with a configurable plugin parameter and adds ---.

@Frodox
Copy link
Contributor

Frodox commented Mar 4, 2016

+1

@james2doyle
Copy link
Member

This looks good. But should there be a test for this?

Nevermind. I didn't look close enough.

james2doyle added a commit that referenced this pull request Mar 19, 2016
@james2doyle james2doyle merged commit 8b77408 into PhileCMS:develop Mar 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants