Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add method Model\Page::getPlainContent() #242

Merged
merged 2 commits into from
May 18, 2015

Conversation

Schlaefer
Copy link
Member

Introduces a Model\Page::getPlainContent() which returns the unparsed page content.

The existing Model\Page::getContent() is O.K. for the core but often not very well suited for plugins:

  • result is parsed (HTML tags not desired/needed, performance impact)
  • triggers parser events (side effects, potential for endless recursion)

I'm not particularly happy with the method name, so if someone has a better idea?

@kicken
Copy link
Contributor

kicken commented May 1, 2015

I typically name methods like that with 'raw', as in getRawContent. I think the current name is fine though.

@james2doyle
Copy link
Member

+1 for getRawContent()

Schlaefer added a commit that referenced this pull request May 18, 2015
add method Model\Page::getPlainContent()
@Schlaefer Schlaefer merged commit edb490b into PhileCMS:develop May 18, 2015
@Schlaefer Schlaefer deleted the feature/getPlain branch May 18, 2015 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants