Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump org.openapitools:openapi-generator-cli from 7.6.0 to 7.7.0 #29

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 11, 2024

Bumps org.openapitools:openapi-generator-cli from 7.6.0 to 7.7.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @jasonaowen.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jul 11, 2024
@jasonaowen
Copy link
Contributor

@jasonaowen
Copy link
Contributor

There is a relevant bugfix in this release, which changes the output of our build: OpenAPITools/openapi-generator#15077 .

My understanding of how to test this is to build the front-end against it, which is currently failing; I'm not yet sure why.

TS2322: Type 'Date' is not assignable to type 'string'.
     9 | 	scope: BaseField.ScopeEnum.Proposal,
    10 | 	dataType: BaseField.DataTypeEnum.String,
  > 11 | 	createdAt: new Date(),
       | 	^^^^^^^^^
    12 | };
    13 |
    14 | const baseFieldOrgCity: BaseField = {

@jasonaowen jasonaowen requested a review from slifty August 1, 2024 22:14
@jasonaowen
Copy link
Contributor

@dependabot rebase

Bumps org.openapitools:openapi-generator-cli from 7.6.0 to 7.7.0.

---
updated-dependencies:
- dependency-name: org.openapitools:openapi-generator-cli
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/gradle/org.openapitools-openapi-generator-cli-7.7.0 branch from 1666a10 to 2dfcc93 Compare August 5, 2024 22:36
Copy link
Contributor

@jasonaowen jasonaowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding of how to test this is to build the front-end against it, which is currently failing; I'm not yet sure why.

There hasn't been a new SDK published since #26, which caused the type of the various createdAt fields to change from Date to string. The build failure is from switching the TypeScript SDK from the published version built with Swagger Codegen to the currently unpublished version built with OpenAPI Generator.

I've been able to fix the front-end locally to work with the new SDK, installed into front-end via npm link. With that change, both the current version of openapi-generator-cli and the new version introduced by this PR generate working TypeScript SDKs.

@jasonaowen
Copy link
Contributor

@dependabot merge

@dependabot dependabot bot merged commit a5b48c4 into main Aug 5, 2024
@dependabot dependabot bot deleted the dependabot/gradle/org.openapitools-openapi-generator-cli-7.7.0 branch August 5, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant