Skip to content

Upgrade to Polkadot 0.9.29 #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jasl merged 5 commits into from
Sep 13, 2022
Merged

Upgrade to Polkadot 0.9.29 #947

jasl merged 5 commits into from
Sep 13, 2022

Conversation

@jasl
Copy link
Contributor

@jasl jasl commented Sep 9, 2022 •
edited
Loading

paritytech/substrate@polkadot-v0.9.28...polkadot-v0.9.29

This PR changes:

@jasl jasl marked this pull request as draft September 9, 2022 09:16
@jasl jasl requested a review from kvinwang September 12, 2022 19:49
jasl
jasl commented Sep 12, 2022
View reviewed changes
crates/phactory/src/light_validation/storage_proof.rs
TrieDB::new(&self.db, &self.root)
.map_err(|_| anyhow::Error::msg(Error::StorageRootMismatch))
fn trie(&self) -> TrieDB<H> {
TrieDBBuilder::new(&self.db, &self.root).build()
Copy link
Contributor Author

@jasl jasl Sep 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/paritytech/trie/blob/master/trie-db/src/triedb.rs#L81
it always success now

jasl
jasl commented Sep 12, 2022
View reviewed changes
crates/phactory/src/light_validation/mod.rs
pub enum Error {
// InvalidStorageProof,
StorageRootMismatch,
// StorageRootMismatch,
Copy link
Contributor Author

@jasl jasl Sep 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It used for build TrieDB failed, but now it always success https://github.com/paritytech/trie/blob/master/trie-db/src/triedb.rs#L81

jasl
jasl commented Sep 12, 2022
View reviewed changes
crates/pink/src/runtime.rs
impl Convert<Weight, Balance> for PinkRuntime {
fn convert(w: Weight) -> Balance {
w as _
w.ref_time() as _
Copy link
Contributor Author

@jasl jasl Sep 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/paritytech/substrate/blob/polkadot-v0.9.29/frame/contracts/src/tests.rs#L340

@jasl jasl marked this pull request as ready for review September 12, 2022 19:56
@jasl
Copy link
Contributor Author

jasl commented Sep 12, 2022 •
edited
Loading

Upgrade rustc may broken some test samples, need update them

kvinwang
kvinwang approved these changes Sep 13, 2022
View reviewed changes
Copy link
Collaborator

@kvinwang kvinwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasl jasl merged commit 13f32eb into master Sep 13, 2022
@jasl jasl deleted the polkadot-v0.9.29 branch September 13, 2022 08:14
@jasl jasl mentioned this pull request Sep 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kvinwang kvinwang kvinwang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jasl @kvinwang