Skip to content

Comments

Update to latest Substrate #583

Merged
jasl merged 2 commits intomasterfrom
polkadot-v0.9.13
Nov 27, 2021
Merged

Update to latest Substrate #583
jasl merged 2 commits intomasterfrom
polkadot-v0.9.13

Conversation

@jasl
Copy link
Contributor

@jasl jasl commented Nov 26, 2021

Polkadot v0.9.13 rebased to latest Substrate, this follow it and fix compiling error

Ref:

Note:

test running_the_node_works_and_can_be_interrupted ... FAILED
test running_two_nodes_with_the_same_ws_port_should_work ... FAILED

failures:

---- running_the_node_works_and_can_be_interrupted stdout ----
thread 'running_the_node_works_and_can_be_interrupted' panicked at 'called `Result::unwrap()` on an `Err` value: Elapsed(())', standalone/node/tests/running_the_node_and_interrupt.rs:48:54
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- running_two_nodes_with_the_same_ws_port_should_work stdout ----
thread 'running_two_nodes_with_the_same_ws_port_should_work' panicked at 'assertion failed: `(left == right)`
  left: `Ok(false)`,
 right: `Ok(true)`: The first node must exit gracefully', standalone/node/tests/running_the_node_and_interrupt.rs:83:5

Some minor tests failed in my Mac, let see what CI say

@jasl
Copy link
Contributor Author

jasl commented Nov 26, 2021

https://github.com/Phala-Network/phala-blockchain/runs/4337232710?check_suite_focus=true#step:5:4412

Found unsupported syscalls:
Calling (202) at 0x28d467 in sym.std::thread::park::hdaf33aa7081d18ec

@kvinwang

@kvinwang
Copy link
Collaborator

Found unsupported syscalls:

Should be fixed.


let method_name = item_method.sig.ident.to_string();
let selector = Selector::new(method_name.as_bytes()).into_be_u32();
let selector = Selector::compute(method_name.as_bytes()).into_be_u32();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasl jasl merged commit f552c5f into master Nov 27, 2021
@jasl jasl deleted the polkadot-v0.9.13 branch November 27, 2021 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants