Repository navigation
fix(site): starlight 0.42 removed tagline, so the config that set it stops the build - #62
Merged
Merged
Conversation
…t stops the build Dependabot's grouped npm bump (#61) carries `@astrojs/starlight` 0.41.10 -> 0.42.0, and 0.42.0 removes the top-level `tagline` option outright. Starlight validates its config strictly, so an unrecognised key is a hard error rather than a warning: `astro sync` — the first thing all three site jobs run — dies with [AstroUserError] Invalid config passed to starlight integration Hint: Unrecognized key: "tagline" which reds "Static build and publication contract", "Lighthouse performance budgets" and "Browser, accessibility, privacy, and visual regression" together, plus the Vercel deployment. Three red jobs and one failed deploy, all one unrecognised key. The upstream entry (withastro/starlight#3572) is explicit about the migration: "Removes the `tagline` configuration option, which was never used" — no replacement, safe to delete. So the sentence this repo had been setting there ("Generated from the tagged source this site was built from.") rendered NOWHERE on 0.41 either. Deleting the key changes no pixel, and the comment in its place says that, plus where the fact belongs if it is worth surfacing: page content, not a key the framework ignored. Verified in the order that makes it evidence rather than hope: reproduced the CI failure locally FIRST (`astro sync` exit 1, same "Unrecognized key" hint) against the bumped lockfile, then applied the deletion and re-ran. - `astro sync` exit 0; `npm run build` 43 pages, exit 0. - `npm run test:static` exit 0 — 5 marketing routes + 33 docs pages + registry index + 2 blog + 1 compare validated, 117 research cross-links resolved, registry render contract verified. - `npx playwright test` **139 passed** — including the visual-regression suite against the committed darwin baselines, so the `lucide-react` 1.37 -> 1.41 and astro/react bumps riding along change no rendered pixel. That was the live risk in taking this group. - `node scripts/lighthouse-audit.mjs` exit 0 — performance/accessibility/best-practices/seo 100 on every audited route. `npm audit --audit-level=moderate` exits 1 with 6 vulnerabilities (1 moderate, 5 high: browserslist, fast-uri, js-yaml, nanoid, postcss, undici). Measured against main's lockfile under the same command: byte-for-byte the same six. This bump introduces none of them — they are pre-existing transitive debt and want their own change, so they are reported here rather than folded in silently or used as a reason to hold the fix. <!-- no-visual-delta --> **Why no screenshot:** the deleted key rendered nothing on either version — upstream removed it as "never used" — and the visual-regression suite passing against unchanged baselines is the stronger evidence that the page is identical. Closes #61 Signed-off-by: Keyur Golani <keyurrgolani@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(site): starlight 0.42 removed
tagline, so the config that set it stops the buildDependabot's grouped npm bump (#61) carries
@astrojs/starlight0.41.10 -> 0.42.0, and 0.42.0removes the top-level
taglineoption outright. Starlight validates its config strictly, so anunrecognised key is a hard error rather than a warning:
astro sync— the first thing all threesite jobs run — dies with
which reds "Static build and publication contract", "Lighthouse performance budgets" and
"Browser, accessibility, privacy, and visual regression" together, plus the Vercel deployment.
Three red jobs and one failed deploy, all one unrecognised key.
The upstream entry (withastro/starlight#3572) is explicit about the migration: "Removes the
taglineconfiguration option, which was never used" — no replacement, safe to delete. So thesentence this repo had been setting there ("Generated from the tagged source this site was built
from.") rendered NOWHERE on 0.41 either. Deleting the key changes no pixel, and the comment in
its place says that, plus where the fact belongs if it is worth surfacing: page content, not a
key the framework ignored.
Verified in the order that makes it evidence rather than hope: reproduced the CI failure locally
FIRST (
astro syncexit 1, same "Unrecognized key" hint) against the bumped lockfile, thenapplied the deletion and re-ran.
astro syncexit 0;npm run build43 pages, exit 0.npm run test:staticexit 0 — 5 marketing routes + 33 docs pages + registry index + 2 blog +1 compare validated, 117 research cross-links resolved, registry render contract verified.
npx playwright test139 passed — including the visual-regression suite against thecommitted darwin baselines, so the
lucide-react1.37 -> 1.41 and astro/react bumps ridingalong change no rendered pixel. That was the live risk in taking this group.
node scripts/lighthouse-audit.mjsexit 0 — performance/accessibility/best-practices/seo 100on every audited route.
npm audit --audit-level=moderateexits 1 with 6 vulnerabilities (1 moderate, 5 high:browserslist, fast-uri, js-yaml, nanoid, postcss, undici). Measured against main's lockfile
under the same command: byte-for-byte the same six. This bump introduces none of them — they are
pre-existing transitive debt and want their own change, so they are reported here rather than
folded in silently or used as a reason to hold the fix.
Why no screenshot: the deleted key rendered nothing on either version — upstream removed it
as "never used" — and the visual-regression suite passing against unchanged baselines is the
stronger evidence that the page is identical.
Closes #61
Signed-off-by: Keyur Golani keyurrgolani@gmail.com