Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows empty lines in RPP files #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allows empty lines in RPP files #3

wants to merge 1 commit into from

Conversation

qubitstream
Copy link

  • previously, the parse failed if it encountered an empty line
    due to an IndexError
  • some extensions apparently can add empty lines
  • an example of such a file is in tests/data/with_empty_lines.RPP

@qubitstream
Allows empty lines in RPP files
a9dd9b1 
 - previously, the parse failed if it encountered an empty line
   due to an IndexError
 - some extensions apparently can add empty lines
 - an example of such a file is in tests/data/with_empty_lines.RPP
@Perlence
Copy link
Owner

Perlence commented Oct 31, 2020 •
edited
Loading

Hello @qubitstream, I'm sorry for the late notice.

Does the extension work OK if you remove the empty line and load the project in REAPER?

@kokounet
Copy link

kokounet commented Oct 2, 2023 •
edited
Loading

The way it's implemented in this PR makes it unable to restore those empty lines when writing the file.

Instead, starts_with_quote and starts_with_pipe (scanner.py:68-75) should just return False if the string is empty, similarly to how the startswith method work in python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qubitstream @Perlence @kokounet