Incorrect calculation of duration for grace notes

[cwitkowitz]

If the aim of GraceEffect.durationTime is to return the time of the grace note in ticks, I believe the contents of the function are incorrect:

PyGuitarPro/guitarpro/models.py

Line 980 in c2044d9

return int(Duration.quarterTime / 16 * self.duration)

and should be int(Duration.quarterTime * 4 / self.duration) instead. This is also reflected in parts of the Duration class.

[Perlence]

Hey @cwitkowitz, you are right.

However, what do you mean, it's reflected in parts of the Duration class?

[cwitkowitz]

Thanks for fixing this. I simply meant that a similar formula is followed to compute time in the Duration class:

PyGuitarPro/guitarpro/models.py

Line 442 in 066ecbf

minTime = quarterTime * 4 // sixtyFourth * 2 // 3

PyGuitarPro/guitarpro/models.py

Line 450 in 066ecbf

result = self.quarterTime * 4 // self.value

[Perlence]

I see, got it!