safer cleanup when failing to compile regexps #21683

tonycoz · 2023-12-03T22:17:33Z

Prior to this commit when producing a warning the regexp compiler would check if the warning category was marked as FATAL, and if it was it would add clean up to the save stack to release buffers used during compilation and to release the working REGEXP SV.

This causes two type of problems:

if an error was already queued, Perl_ck_warner() returns even if the warning is fatal, this meant that the normal clean up code Perl_re_op_compile() would also run, resulting in a double free of the buffers.
without fatal warnings, if a $SIG{WARN} handler died, the buffers and the working REGEXP SV would leak.

Avoid this by using SAVEDESTRUCTOR_X() to release the memory and optionally the SV at the end of scope.

Fixes #21661

regcomp.c

regcomp_internal.h

demerphq · 2024-03-07T18:33:39Z

@tonycoz looks like this can be merged?

jkeenan · 2024-08-03T11:19:36Z

@tonycoz, this p.r. has had merge conflicts for close to 5 months. Do you intend to go forward with it? If not, please consider closing it. Thanks.

Prior to this commit when producing a warning the regexp compiler would check if the warning category was marked as FATAL, and if it was it would add clean up to the save stack to release buffers used during compilation and to release the working REGEXP SV. This causes two type of problems: - if an error was already queued, Perl_ck_warner() returns even if the warning is fatal, this meant that the normal clean up code Perl_re_op_compile() would also run, resulting in a double free of the buffers. - without fatal warnings, if a $SIG{__WARN__} handler died, the buffers and the working REGEXP SV would leak. Avoid this by using SAVEDESTRUCTOR_X() to release the memory and optionally the SV at the end of scope. Fixes #21661

These can be simpler, and since we allow use of __VA_ARGS__ we can consolidate Simple_vFAIL[1-4]() into Simple_vFAILn()

We are now always prepared for death.

mauke · 2024-08-03T12:02:19Z

I've rebased the PR on top of blead and removed the conflicts. Unless someone objects (or beats me to the punch), I intend on merging this within a day or two.