feat: procedural sun

.claude/CLAUDE.md

@@ -21,22 +21,38 @@ powershell.exe -Command "./BuildRelease.bat [PRESET_NAME]"
 
 **Available Presets** (from CMakePresets.json):
 
--   `ALL` (default) - Builds for SE/AE/VR in single binary
--   `SE` - Skyrim Special Edition only
--   `AE` - Anniversary Edition only
--   `VR` - Skyrim VR only
--   `ALL-TRACY` - Includes Tracy profiler support
--   `ALL-WITH-AUTO-DEPLOYMENT` - Auto-deploys to configured Skyrim directories when template used.
+-   `ALL` (default) - Builds universal binary supporting SE/AE/VR runtime detection
+-   `SE` - Skyrim Special Edition only (compile-time targeting)
+-   `AE` - Anniversary Edition only (compile-time targeting)
+-   `VR` - Skyrim VR only (compile-time targeting)
+-   `PRE-AE` - SE + VR (excludes AE)
+-   `FLATRIM` - SE + AE (excludes VR)
+-   `ALL-TRACY` - Universal binary with Tracy profiler support enabled
+
+**User Preset Template**:
+
+-   `ALL-WITH-AUTO-DEPLOYMENT` - Extends `ALL` with `AUTO_PLUGIN_DEPLOYMENT=ON` (copy template to use)
 
 ### Development Setup
 
 1. Copy `CMakeUserPresets.json.template` → `CMakeUserPresets.json`
 2. Configure `CommunityShadersOutputDir` for auto-deployment to Skyrim installations
-3. Set build options in user preset:
-    - `AUTO_PLUGIN_DEPLOYMENT`: Auto-copy to Skyrim dirs
-    - `AIO_ZIP_TO_DIST`: Creates all-in-one distribution package
-    - `ZIP_TO_DIST`: Creates individual feature packages
-    - `TRACY_SUPPORT`: Enables performance profiling
+3. Set build options in user preset or CMake cache:
+
+**Build Options** (CMake cache variables):
+
+-   `AUTO_PLUGIN_DEPLOYMENT` (default: OFF) - Auto-copy build output to `CommunityShadersOutputDir`
+-   `ZIP_TO_DIST` (default: ON) - Creates individual feature packages as 7z files in `/dist`
+-   `AIO_ZIP_TO_DIST` (default: ON) - Creates all-in-one distribution package as 7z in `/dist`
+-   `TRACY_SUPPORT` (default: OFF) - Enables Tracy profiler integration for performance analysis
+
+**Auto-Deployment Configuration**:
+
+Set `CommunityShadersOutputDir` environment variable to semicolon-separated Skyrim Data directories:
+
+```
+CommunityShadersOutputDir=F:/MySkyrimModpack/mods/CommunityShaders;F:/SteamLibrary/steamapps/common/SkyrimVR/Data;F:/SteamLibrary/steamapps/common/Skyrim Special Edition/Data
+```
 
 ### Shader Development and Testing
 
@@ -73,8 +89,72 @@ hlslkit-generate-defines --log CommunityShaders.log
 hlslkit-buffer-scan --features-dir features/
 ```
 
+### Custom CMake Targets
+
+**Package and Deployment Targets**:
+
+```bash
+# Prepare AIO package structure (automatic with AIO_ZIP_TO_DIST or AUTO_PLUGIN_DEPLOYMENT)
+cmake --build ./build/ALL --target PREPARE_AIO
+
+# Prepare shaders only (useful for CI shader validation)
+cmake --build ./build/ALL --target prepare_shaders
+
+# Copy shaders to deployment directories (when AUTO_PLUGIN_DEPLOYMENT=ON)
+cmake --build ./build/ALL --target COPY_SHADERS
+
+# Create AIO zip package (when AIO_ZIP_TO_DIST=ON)
+cmake --build ./build/ALL --target AIO_ZIP_PACKAGE
+```
+
+**Development Targets**:
+
+```bash
+# Format all C++ and HLSL code (requires clang-format)
+cmake --build ./build/ALL --target FORMAT_CODE
+
+# Generate shader validation configs from game logs (requires PowerShell)
+cmake --build ./build/ALL --target generate_shader_configs
+```
+
 ## Architecture Overview
 
+### Manual packaging targets (detailed)
+
+The project also provides a set of manual packaging targets that create distributable 7z packages or install the project into the AIO folder. These targets are useful when you want precise control over packaging (CI artifacts, local QA, or manual deployment).
+
+Quick commands:
+
+```bash
+# Create the Core package (includes CORE features + plugin DLL)
+cmake --build ./build/ALL --target Package-Core
+
+# Create a manual AIO package (.7z) via install + tar
+cmake --build ./build/ALL --target Package-AIO-Manual
+
+# Create an individual feature package (name is sanitized from the feature folder)
+cmake --build ./build/ALL --target Package-<Feature>
+
+# Install into the AIO folder (installs to build/<preset>/aio)
+cmake --build ./build/ALL --target AIO
+
+# Alternatively use cmake --install to install to a custom prefix
+cmake --install ./build/ALL --prefix <TARGET_DIR>  # installs files according to CMake install() rules
+```
+
+Notes and behaviour:
+
+-   `Package-Core` collects everything marked as CORE and the built plugin into a temporary folder, then tars it to `dist/${PROJECT_NAME}-${UTC_NOW}.7z`.
+-   `Package-<Feature>` targets are generated per feature directory (non-CORE features). They create `${FEATURE}-${UTC_NOW}.7z` in `dist/`.
+-   `Package-AIO-Manual` performs an install to the AIO folder and then creates a single AIO archive. This is similar to the automated `AIO_ZIP_PACKAGE`, but wired as an explicit file-producing custom target (useful for CI reproducibility).
+-   `AIO` target runs `cmake --install` with the `aio` prefix so you can locally inspect the AIO folder layout without creating an archive.
+-   The install-based packaging uses the CMake `install()` rules defined near the top of `CMakeLists.txt` (the project installs `SKSE/Plugins`, copies `package/` and feature folders, and removes the Core placeholder). This makes manual installs and CI artifacts consistent with the runtime AIO layout.
+
+Where to look in `CMakeLists.txt`:
+
+-   Manual packaging targets are defined in the "Manual packaging targets (Package-XXX)" section and create files under `${CMAKE_SOURCE_DIR}/dist`.
+-   The `install()` rules near the top of the file show what gets placed into the AIO layout when running `cmake --install`.
+
 ### Plugin Architecture
 
 **Core Pattern**: Feature-driven modular system where each graphics enhancement is an independent `Feature` class that can be enabled/disabled at runtime.

.coderabbit.yaml

@@ -1,26 +1,27 @@
 # CodeRabbit AI Configuration
 
-instructions: |
-    When reviewing PRs, please provide suggestions for:
-
-    1. **Conventional Commit Titles** (if not following https://www.conventionalcommits.org/ or
-    if the existing title does not describe the code changes):
-       Format: type(scope): description
-       Length: 50 characters limit for title, 72 for body
-       Style: lowercase description, no ending period
-       Examples:
-       - feat(vr): add cross-eye sampling
-       - fix(water): resolve flowmap bug
-       - docs: update shader documentation
+reviews:
+    path_instructions:
+        - path: "**/*"
+          instructions: |
+              When reviewing PRs, please provide suggestions for:
 
-    2. **Issue References** (if PR fixes bugs or implements features):
-       Suggest adding appropriate GitHub keywords:
-       - "Fixes #123" or "Closes #123" for bug fixes
-       - "Implements #123" or "Addresses #123" for features
-       - "Related to #123" for partial implementations
+              1. **Conventional Commit Titles** (if not following https://www.conventionalcommits.org/ or
+              if the existing title does not describe the code changes):
+                 Format: type(scope): description
+                 Length: 50 characters limit for title, 72 for body
+                 Style: lowercase description, no ending period
+                 Examples:
+                 - feat(vr): add cross-eye sampling
+                 - fix(water): resolve flowmap bug
+                 - docs: update shader documentation
 
-    Otherwise, use your standard review approach focusing on code quality.
+              2. **Issue References** (if PR fixes bugs or implements features):
+                 Suggest adding appropriate GitHub keywords:
+                 - "Fixes #123" or "Closes #123" for bug fixes
+                 - "Implements #123" or "Addresses #123" for features
+                 - "Related to #123" for partial implementations
 
-reviews:
+              Otherwise, use your standard review approach focusing on code quality.
     path_filters:
         - "**/*.hlsl"

.github/workflows/build.yaml

@@ -36,6 +36,9 @@ on:
             - "vcpkg-configuration.json"
             - ".gitmodules"
             - "extern/**"
+            - "cmake/**"
+            - ".github/workflows/**"
+            - ".github/configs/**"
 
 permissions:
     contents: read
@@ -52,7 +55,7 @@ jobs:
         if: ${{ github.event_name == 'pull_request_target' }}
         outputs:
             should-build: ${{ steps.changed-files.outputs.build_any_changed == 'true' || steps.changed-files.outputs.cpp_any_changed == 'true' || steps.changed-files.conclusion == 'failure' }}
-            hlsl-should-build: ${{ steps.changed-files.outputs.hlsl_any_changed == 'true' || steps.changed-files.conclusion == 'failure' }}
+            hlsl-should-build: ${{ steps.changed-files.outputs.hlsl_any_changed == 'true' || steps.changed-files.outputs.cmake_any_changed == 'true' || steps.changed-files.outputs.ci_any_changed == 'true' || steps.changed-files.conclusion == 'failure' }}
         steps:
             - uses: actions/checkout@v4
               with:
@@ -86,6 +89,13 @@ jobs:
                         - 'vcpkg-configuration.json'
                         - '.gitmodules'
                         - 'extern/**'
+                      cmake:
+                        - 'CMakeLists.txt'
+                        - 'CMakePresets.json'
+                        - 'cmake/**'
+                      ci:
+                        - '.github/workflows/**'
+                        - '.github/configs/**'
                       hlsl:
                         - '**.hlsl'
                         - '**.hlsli'
@@ -387,6 +397,37 @@ jobs:
               with:
                   vcpkgJsonGlob: vcpkg.json
 
+            - name: Locate fxc.exe
+              if: steps.check-hlsl.outputs.skip != 'true'
+              id: find_fxc
+              shell: pwsh
+              run: |
+                  # Try to find fxc.exe on PATH first
+                  $fxcCmd = Get-Command -Name fxc.exe -ErrorAction SilentlyContinue
+                  if ($fxcCmd) {
+                    $fxcPath = $fxcCmd.Source
+                    Write-Host "Found fxc.exe at $fxcPath"
+                    Add-Content -Path $env:GITHUB_OUTPUT -Value "fxc_path=$fxcPath"
+                  } else {
+                    # Try known Windows SDK locations (x64)
+                    $fxcPath = ''
+                    $sdkRoot = 'C:\Program Files (x86)\Windows Kits\10\bin'
+                    if (Test-Path $sdkRoot) {
+                      $versions = Get-ChildItem -Path $sdkRoot -Directory | Sort-Object -Descending
+                      foreach ($v in $versions) {
+                        $candidate = Join-Path $v.FullName 'x64\fxc.exe'
+                        if (Test-Path $candidate) { $fxcPath = $candidate; break }
+                      }
+                    }
+                    if ($fxcPath -ne '') {
+                      Write-Host "Found fxc.exe at $fxcPath"
+                      Add-Content -Path $env:GITHUB_OUTPUT -Value "fxc_path=$fxcPath"
+                    } else {
+                      Write-Warning "fxc.exe not found in PATH or common SDK locations"
+                      Add-Content -Path $env:GITHUB_OUTPUT -Value "fxc_path="
+                    }
+                  }
+
             - name: Cache CMake build output
               if: steps.check-hlsl.outputs.skip != 'true'
               uses: actions/cache@v4
@@ -437,7 +478,12 @@ jobs:
 
             - name: Validate shader compilation (${{ matrix.config.name }})
               if: steps.check-hlsl.outputs.skip != 'true'
-              run: hlslkit-compile --shader-dir build/ALL/aio/Shaders --output-dir build/ShaderCache --config ${{ matrix.config.file }} --max-warnings 0 --suppress-warnings X1519
+              run: |
+                  if [ -z "${{ steps.find_fxc.outputs.fxc_path }}" ]; then
+                    echo "fxc.exe not found - shader validation requires fxc.exe. Set --fxc to a valid path or ensure fxc.exe is in PATH." >&2
+                    exit 1
+                  fi
+                  hlslkit-compile --fxc "${{ steps.find_fxc.outputs.fxc_path }}" --shader-dir build/ALL/aio/Shaders --output-dir build/ShaderCache --config ${{ matrix.config.file }} --max-warnings 0 --suppress-warnings X1519
               shell: bash
 
             - name: Upload shader validation logs

.gitmodules

@@ -4,3 +4,6 @@
 [submodule "extern/Streamline-DX12"]
 	path = extern/Streamline-DX12
 	url = https://github.com/NVIDIAGameWorks/Streamline.git
+[submodule "extern/FidelityFX-SDK"]
+	path = extern/FidelityFX-SDK
+	url = https://github.com/MapleHinata/FidelityFX-SDK

.pre-commit-config.yaml

@@ -22,6 +22,11 @@ repos:
             additional_dependencies: ["prettier@3.1.0"]
             files: \.(json|md|yml|yaml)$
             exclude: ^(\.\/)?(extern|include|build|dist)\/
+    - repo: https://github.com/BlankSpruce/gersemi
+      rev: 0.22.3
+      hooks:
+          - id: gersemi
+            files: '(^CMakeLists.txt$|.*\\.cmake$)'
 ci:
     autofix_commit_msg: |
         style: 🎨 apply pre-commit.ci formatting

AI-INSTRUCTIONS.md

@@ -26,6 +26,26 @@ SKSE plugin providing advanced DirectX 11 graphics modifications for Skyrim SE/A
 -   **Shader Test**: `hlslkit-compile --shader-dir [target]` (install via pip first)
 -   **Feature Access**: `globals::features::*` namespace
 
+### Build Options
+
+**Runtime Presets**: `ALL` (universal), `SE`, `AE`, `VR`, `PRE-AE`, `FLATRIM`, `ALL-TRACY`
+
+**CMake Options** (set in user preset):
+
+-   `AUTO_PLUGIN_DEPLOYMENT=ON` - Auto-copy to `CommunityShadersOutputDir`
+-   `ZIP_TO_DIST=ON` (default) - Create individual feature 7z packages
+-   `AIO_ZIP_TO_DIST=ON` (default) - Create all-in-one 7z package
+-   `TRACY_SUPPORT=ON` - Enable Tracy profiler integration
+
+### Custom CMake Targets
+
+**Quick targets** (common):
+
+-   `PREPARE_AIO`, `prepare_shaders`, `COPY_SHADERS`, `AIO_ZIP_PACKAGE`
+-   `FORMAT_CODE`, `generate_shader_configs`
+
+For full details about manual packaging targets (Package-Core, Package-AIO-Manual, Package-<Feature>, AIO) and example workflows, see the "Manual packaging targets (detailed)" section in `.claude/CLAUDE.md` to avoid duplication.
+
 ### AI Assistant Role
 
 **Act as an experienced graphics programming and Skyrim modding expert.**