Add support for compressed double factorization #6611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
obliviateandsurrender
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6611 +/- ##
=======================================
Coverage 99.65% 99.65%
=======================================
Files 455 455
Lines 42936 42993 +57
=======================================
+ Hits 42787 42844 +57
Misses 149 149 ☔ View full report in Codecov by Sentry. |
soranjh
requested changes
Nov 25, 2024
There was a problem hiding this comment.
Thanks @obliviateandsurrender, left some comments, the main ones being:
- Not sure we need hard-coded jax and jit optimisation.
- Will be great if the private functions called by factorise have same return type.
soranjh
reviewed
Nov 26, 2024
ddhawan11
requested changes
Nov 27, 2024
soranjh
approved these changes
Nov 28, 2024
DSGuala
approved these changes
Nov 28, 2024
ddhawan11
approved these changes
Nov 29, 2024
ddhawan11
reviewed
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: This adds a compressed-based double factorization routine with optional regularization.
Description of the Change: A
compressedkwarg has been added to the pennylane.qchem.factorize function along with support for adding some compression-based kwargs.Benefits: We have a more tunable and scalable method for obtaining double factorization.
Possible Drawbacks: N/A
Related GitHub Issues: [sc-72646]