Fix coverage due to removal of max_expansion in clifford_t_decomposition.py
#6571
+54
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrijapau
commented
Nov 11, 2024
andrijapau
commented
Nov 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6571 +/- ##
==========================================
+ Coverage 99.28% 99.33% +0.04%
==========================================
Files 452 452
Lines 43059 43040 -19
==========================================
+ Hits 42752 42754 +2
+ Misses 307 286 -21 ☔ View full report in Codecov by Sentry. |
andrijapau
commented
Nov 11, 2024
andrijapau
commented
Nov 11, 2024
andrijapau
commented
Nov 15, 2024
albi3ro
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
#6531 was accidentally merged into master with a net negative hit to the project code coverage. This PR is designed to reconcile that impact and clean-up the coverage.
Description of the Change:
The following logic branches were removed because they are not possible to reach given the deprecation/removal of
expand_depthincompile.py.For the sake of record keeping, comments by me are attached to each logic branch indicating why it was removed.
Benefits: Restore original project code coverage.
Possible Drawbacks: None that I know of.
[sc-77499]