Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GQSP template and angle solver #6565

Merged
merged 56 commits into from
Dec 6, 2024
Merged

GQSP template and angle solver #6565

merged 56 commits into from
Dec 6, 2024

Conversation

KetpuntoG
Copy link
Contributor

@KetpuntoG KetpuntoG commented Nov 11, 2024

  • Add thumbnail
  • Add changelog

This PR introduces the Generalized QSP template and some functionality to calculate the desire polynomials.

[sc-76734]

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.
Copy link
Contributor

@obliviateandsurrender obliviateandsurrender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @KetpuntoG! Leaving a few comments.

Base automatically changed from angle_solver_qsp to master November 29, 2024 22:28
Copy link
Contributor

@obliviateandsurrender obliviateandsurrender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing my requested changes, so not to be a blocker for the PR.

KetpuntoG and others added 2 commits December 3, 2024 09:25
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
Copy link
Contributor

@soranjh soranjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KetpuntoG, added some small comments. Looks good overall.

@KetpuntoG KetpuntoG requested a review from soranjh December 4, 2024 22:46
@KetpuntoG KetpuntoG removed the do not merge ⚠️ Do not merge the pull request until this label is removed label Dec 5, 2024
Copy link
Contributor

@soranjh soranjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go :shipit:

KetpuntoG and others added 2 commits December 6, 2024 09:57
Co-authored-by: Soran Jahangiri <40344468+soranjh@users.noreply.github.com>
@KetpuntoG KetpuntoG merged commit 5410faa into master Dec 6, 2024
46 checks passed
@KetpuntoG KetpuntoG deleted the gqsp_template_solver branch December 6, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants