-
Notifications
You must be signed in to change notification settings - Fork 632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GQSP template and angle solver #6565
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @KetpuntoG! Leaving a few comments.
[skip ci] Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
…/pennylane into gqsp_template_solver
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing my requested changes, so not to be a blocker for the PR.
Co-authored-by: Utkarsh <utkarshazad98@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @KetpuntoG, added some small comments. Looks good overall.
Co-authored-by: Soran Jahangiri <40344468+soranjh@users.noreply.github.com>
…/pennylane into gqsp_template_solver
…/pennylane into gqsp_template_solver
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go
Co-authored-by: Soran Jahangiri <40344468+soranjh@users.noreply.github.com>
This PR introduces the Generalized QSP template and some functionality to calculate the desire polynomials.
[sc-76734]