Added standard Binary mapping for bosonic operators #6564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Diksha Dhawan <40900030+ddhawan11@users.noreply.github.com>
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6564 +/- ##
=======================================
Coverage 99.46% 99.46%
=======================================
Files 454 455 +1
Lines 42651 42717 +66
=======================================
+ Hits 42422 42488 +66
Misses 229 229 ☔ View full report in Codecov by Sentry. |
austingmhuang
requested changes
Nov 11, 2024
There was a problem hiding this comment.
@ddhawan11 Nice work! I left some pretty basic comments for now. I will take a closer look at the bosonic_mapping in greater detail later, hopefully with some more interesting and useful questions or comments.
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
Co-authored-by: Austin Huang <65315367+austingmhuang@users.noreply.github.com>
Co-authored-by: Austin Huang <65315367+austingmhuang@users.noreply.github.com>
ddhawan11
commented
Nov 22, 2024
austingmhuang
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
@ddhawan11 Great work! Conditional approval based on making sure the example in the docs work and editing the docstrings to follow the PL style guide.
DSGuala
approved these changes
Nov 22, 2024
Co-authored-by: Diego <67476785+DSGuala@users.noreply.github.com>
Co-authored-by: Diego <67476785+DSGuala@users.noreply.github.com>
soranjh
approved these changes
Nov 25, 2024
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
Co-authored-by: soranjh <40344468+soranjh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Standard-binary mapping for bosonic operators
Description of the Change:
Added function for mapping bosonic operators (BoseWord and BoseSentence) to qubit operators.
Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-72640]