[Capture] higher order primitives store slices instead of integers #6521
+81
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
dwierichs
approved these changes
Nov 6, 2024
mudit2812
approved these changes
Nov 7, 2024
Co-authored-by: David Wierichs <david.wierichs@xanadu.ai>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6521 +/- ##
=======================================
Coverage 99.34% 99.34%
=======================================
Files 455 456 +1
Lines 43193 43265 +72
=======================================
+ Hits 42909 42981 +72
Misses 284 284 ☔ View full report in Codecov by Sentry. |
mudit2812
pushed a commit
that referenced
this pull request
Nov 11, 2024
…6521) **Context:** As the higher order primitives `for`, `while`, and `cond` get more feature-rich, especially with the incoming changes for dynamically shaped arrays, it can be hard to keep track of what order the arguments come in. This will get harder when we have to add in more positional arguments for the dynamically shaped array dimensions. **Description of the Change:** Updates `for`, `while` and `cond` to store slices into the positionally arguments instead of numbers of the different types of arguments. Now we can simply consume: ``` args[provided_slice] ``` instead of having to do: ``` args[some_calcualtion_for_start: some_calculation_for_end] ``` I also rewrote some of the logic in the for conditional to make it easier to construct all the relevant data. **Benefits:** **Possible Drawbacks:** For the for loop, the slices into the arguments start after the `start, stop, step` instead of including the offset by three. I wasn't quite sure which one made more sense. **Related GitHub Issues:** [sc-77579] --------- Co-authored-by: David Wierichs <david.wierichs@xanadu.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
As the higher order primitives
for,while, andcondget more feature-rich, especially with the incoming changes for dynamically shaped arrays, it can be hard to keep track of what order the arguments come in. This will get harder when we have to add in more positional arguments for the dynamically shaped array dimensions.Description of the Change:
Updates
for,whileandcondto store slices into the positionally arguments instead of numbers of the different types of arguments. Now we can simply consume:instead of having to do:
I also rewrote some of the logic in the for conditional to make it easier to construct all the relevant data.
Benefits:
Possible Drawbacks:
For the for loop, the slices into the arguments start after the
start, stop, stepinstead of including the offset by three. I wasn't quite sure which one made more sense.Related GitHub Issues:
[sc-77579]