Add helper func apply_operation for default mixed
#6379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
JerryChen97
changed the title
apply_operation for default mixedapply_operation for default mixed
|
RN I've done the implementation of both einsum and tensordot.
Due to the fact that there are quite some other shortcuting regeisters for many special cases to implement, currently I would like to put this as draft without the full CI. After all the other registers complete I will load the CI along with more tests. |
|
In previous |
|
The following methods involve additional stories and will be neglected for now:
|
mudit2812
reviewed
Oct 31, 2024
mudit2812
reviewed
Oct 31, 2024
Co-authored-by: Mudit Pandey <[email protected]>
Co-authored-by: Mudit Pandey <[email protected]>
Co-authored-by: Mudit Pandey <[email protected]>
Co-authored-by: Mudit Pandey <[email protected]>
Co-authored-by: Mudit Pandey <[email protected]>
…aneAI/pennylane into add-apply-operation-mixed
|
All resolved! @mudit2812 |
mudit2812
reviewed
Nov 1, 2024
mudit2812
reviewed
Nov 1, 2024
mudit2812
approved these changes
Nov 1, 2024
mudit2812
added a commit
that referenced
this pull request
Nov 11, 2024
**Context:** Before getting into the implementation of new `default_mixed` we need to separate most of the useful logics from the older version one. One of the most important things is the `apply_operation`. Basically, what we want to do is to condensate everything into a new sub-module under `qml/devices/qubit_mixed` such that previous empirical heuristics regarding how to select between `einsum` and `tensordot` can be carried over and wrapped independently. **Description of the Change:** New script containing the helper funcs as described above. **Benefits:** Better modularization. Getting ready for the implementaion of a new `default_mixed` in the future. **Possible Drawbacks:** **Related GitHub Issues:** **Related Shortcut Stories** [sc-73319] --------- Co-authored-by: Mudit Pandey <[email protected]> Co-authored-by: Astral Cai <[email protected]> Co-authored-by: Christina Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Before getting into the implementation of new
default_mixedwe need to separate most of the useful logics from the older version one. One of the most important things is theapply_operation. Basically, what we want to do is to condensate everything into a new sub-module underqml/devices/qubit_mixedsuch that previous empirical heuristics regarding how to select betweeneinsumandtensordotcan be carried over and wrapped independently.Description of the Change:
New script containing the helper funcs as described above.
Benefits:
Better modularization. Getting ready for the implementaion of a new
default_mixedin the future.Possible Drawbacks:
Related GitHub Issues:
Related Shortcut Stories
[sc-73319]