-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cast initial state into complex dtype for default.qubit
+ Update Sum.label
+ fix qml.compile
#6198
Merged
+83
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello. You may have forgotten to update the changelog!
|
mudit2812
changed the title
Cast initial state into complex dtype for
Cast initial state into complex dtype for Aug 31, 2024
default.qubit
default.qubit
+ Update Sum.label
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v0.38.0-rc0 #6198 +/- ##
==============================================
Coverage ? 99.66%
==============================================
Files ? 445
Lines ? 42394
Branches ? 0
==============================================
Hits ? 42252
Misses ? 142
Partials ? 0 ☔ View full report in Codecov by Sentry. |
mudit2812
changed the title
Cast initial state into complex dtype for
Cast initial state into complex dtype for Sep 3, 2024
default.qubit
+ Update Sum.label
default.qubit
+ Update Sum.label
+ fix qml.compile
albi3ro
approved these changes
Sep 3, 2024
astralcai
approved these changes
Sep 3, 2024
mlxd
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading
qml
to numpy 1.25 caused a bunch ofComplexWarning
s to show up because we start out with a float initial state, which most likely gets cast into complex during execution. Then, during backprop, the complex state would get cast into float, which would raise the aforementioned warnings.Sum.label
was also overly detailed, causingqml.draw
to look terrible. I changed the label to be consistent withLinearCombination
andHamiltonian
.qml.compile
was not decomposing state prep ops, which is now changed.