-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch exceptions without JIT compiling the wrapper. #99
Conversation
102b639
to
1f8c34c
Compare
Codecov Report
@@ Coverage Diff @@
## main #99 +/- ##
==========================================
+ Coverage 98.72% 98.75% +0.03%
==========================================
Files 34 35 +1
Lines 5565 5708 +143
Branches 274 274
==========================================
+ Hits 5494 5637 +143
Misses 40 40
Partials 31 31
|
a5851c8
to
b95624a
Compare
With this new solution, on my machine (and therefore not a rigorous benchmark) the compilation time is back to what is expected.
Baseline (no wrapper,
Here is a link to the previous implementation: Please note that this is not a rigorous benchmark but it roughly gives us the idea that things are staying fairly equal. |
a38148a
to
58e83ee
Compare
58e83ee
to
6ca2535
Compare
8850a4a
to
7aa31f6
Compare
1c5246e
to
59a4fb7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll have to wait for approval from @maliasadi but looks good to me 👍
Co-authored-by: David Ittah <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Context: Add a pybind wrapper to translate C++ expcetions to Python exceptions.
Description of the Change: Does not use libffi. Depends on #106.
Benefits: No compilation time spent in the wrapper. No dependency on libffi. Better UX.