Workflow and test driver fixes #18
Conversation
* increase fetch depth and update regex * updated action deps, relaxed run criteria * go back to "normal" tokens, remove permission hacks * still needs more job isolation => refactor for another day Signed-off-by: Stephen L Arnold <[email protected]>
* also fix missing PR event check in coverage workflow Signed-off-by: Stephen L Arnold <[email protected]>
|
So, how often are you doing "internal" org PRs vs (contributed) PRs from forks? Certainly one alternative is just ditch this coverage workflow and use one of the usual coveralls/codecov/whatever provider actions. Lemme know if I should delete it, otherwise this one does work for org PRs (if people are working directly in the repositories) but PR comment bits will not work on forked PRs without a bunch of isolation and passing data from one job/step to another. Sadly I didn't find any GH docs or working examples/issues :/ |
* nose (unmaintained) breaks on python 3.10 * remove some cruft from spectesting.py * update tox file, move deps to setup.cfg * restrict PR comment to org owners, adjust Signed-off-by: Stephen L Arnold <[email protected]>
* update coverage value for delta/base, allow digits only Signed-off-by: Stephen L Arnold <[email protected]>
|
@sarnold – Activity has been close to zero so I don't think we have a standard set of behaviors yet. I'm loathe to delete any tests/workflows that are currently working and potentially useful. Is this PR merge-able? The build system seems to think so. |
The main points:
plus some other tox, workflow, and packaging updates.