Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Make hsvs workflow work #784

Merged
merged 5 commits into from
Jul 18, 2024
Merged

[FIX] Make hsvs workflow work #784

merged 5 commits into from
Jul 18, 2024

Conversation

mattcieslak
Copy link
Collaborator

Addresses #718 and numerous neurostars issues. This fixes the hsvs workflow (specifically the FreeSurfer ingression) which got very broken when we moved to the nipreps config model.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 31.25000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 29.85%. Comparing base (6860e52) to head (6c9bbdf).

Files Patch % Lines
qsiprep/interfaces/bids.py 14.28% 4 Missing and 2 partials ⚠️
qsiprep/workflows/recon/anatomical.py 0.00% 3 Missing ⚠️
qsiprep/interfaces/freesurfer.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #784   +/-   ##
=======================================
  Coverage   29.84%   29.85%           
=======================================
  Files          97       97           
  Lines       14604    14613    +9     
  Branches     1885     1887    +2     
=======================================
+ Hits         4359     4362    +3     
- Misses      10117    10121    +4     
- Partials      128      130    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattcieslak mattcieslak merged commit 6a00f6c into master Jul 18, 2024
2 checks passed
@mattcieslak mattcieslak deleted the fix/hsvs-vars branch July 18, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants