Fix depiction of defaults and organise them #1754
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
reviewed
May 24, 2024
| @@ -11,7 +11,7 @@ import ( | |||
|
|
|||
| "github.com/jackc/pgx/v5" | |||
| "github.com/jackc/pgx/v5/pgxpool" | |||
| "github.com/yuin/gopher-lua" | |||
| lua "github.com/yuin/gopher-lua" | |||
There was a problem hiding this comment.
you should fix your config to stop doing this on save
serprex
reviewed
May 24, 2024
| @@ -0,0 +1,15 @@ | |||
| // These are the backend defaults if the user creates a new mirror | |||
| // via SQL layer without specifying these settings. | |||
| const DefaultSyncInterval = 60; | |||
There was a problem hiding this comment.
this seems like it'll be hard to keep in sync. Ideally we'd have build step read values out of go files
There was a problem hiding this comment.
hack: make defaults protobuf enum
|
not sure if addressed here, but important to differentiate between explicit value matching default & default. For if default changes. Rendering default as placeholder could work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues where some params in overview page would show '0' but they would actually have a default value
Organise default values of :
Snapshot number of tables in parallel
Snapshot number of workers
Snapshot number of rows per partition
Pull batch Size
Sync interval
to constant files in Go and UI
Show these defaults when not set in UI (happens when mirror is created via query layer)
Also show publication name in UI
Functionally tested with creating a mirror from UI and Query Layer