This repository was archived by the owner on Mar 21, 2025. It is now read-only.
Fix resource subscription handling #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add resource subscription tests
4 tasks
Merged. I'll review this PR once you've fixed up the conflicts. Thanks! |
stephentoub
reviewed
Mar 16, 2025
stephentoub
reviewed
Mar 16, 2025
stephentoub
reviewed
Mar 16, 2025
stephentoub
previously approved these changes
Mar 16, 2025
|
|
This PR is ready for review again. |
stephentoub
reviewed
Mar 17, 2025
| } | ||
|
|
||
| private static HashSet<string> _subscribedResources = new(); | ||
| private static readonly object _subscribedResourcesLock = new(); |
There was a problem hiding this comment.
Could also use a ConcurrentDictionary, but this is fine.
There was a problem hiding this comment.
Yes, I considered that, but thought it was overkill for a test server.
stephentoub
approved these changes
Mar 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix resource subscription handling
Add resource subscription tests
Note that the 'everything' server supports resource subscription in the git repo, but the version on npx does not. Hence the lack of integration test against the reference server.
I've added subscribe and unsubscribe logic corresponding to that described in the everything docs to the library (stdio) testserver.
Let's merge #87 before this one (I'll make the changes related to capabilities and handlers in this PR to align with it, once it's merged).