-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MOB-183 - Fix transaction initialisation using access code. #150
Conversation
|
||
buildToolsVersion = "29.0.2" | ||
versionName = "3.2.0-alpha02" | ||
versionName = "3.3.0-alpha02" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version name here and in gradle.properties are inconsistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm updating those on purpose @nathanstasin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our pipelines for versioning aren't updated on this repo. It means there's a little bit of a mismatch in the between versioning on MavenCentral vs the tags here.
org.gradle.unsafe.configuration-cache=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were you having problems with this optimisation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some plugins used aren't compatible. I don't want to have to update them at this time.
paystack/src/main/java/co/paystack/android/api/PaystackRepositoryImpl.kt
Show resolved
Hide resolved
@michael-paystack I see that there's a quality gate failing here is this intentional? |
Yup @ali-paystack we're a little less concerned about test coverage right now (That sounds awful, I know). |
SonarCloud Quality Gate failed. |
|
Hand to the sky, I promise @ali-paystack |
No description provided.