Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOB-183 - Fix transaction initialisation using access code. #150

Merged
merged 4 commits into from
Feb 8, 2023

Conversation

michael-paystack
Copy link
Member

No description provided.


buildToolsVersion = "29.0.2"
versionName = "3.2.0-alpha02"
versionName = "3.3.0-alpha02"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version name here and in gradle.properties are inconsistent.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm updating those on purpose @nathanstasin

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our pipelines for versioning aren't updated on this repo. It means there's a little bit of a mismatch in the between versioning on MavenCentral vs the tags here.

org.gradle.unsafe.configuration-cache=false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you having problems with this optimisation?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some plugins used aren't compatible. I don't want to have to update them at this time.

@michael-paystack michael-paystack changed the title Fix transaction initialisation using access code. MOB-183 - Fix transaction initialisation using access code. Feb 7, 2023
@michael-paystack michael-paystack deleted the initialize-with-access-code branch February 7, 2023 09:42
@michael-paystack michael-paystack restored the initialize-with-access-code branch February 7, 2023 09:44
@ali-paystack
Copy link

@michael-paystack I see that there's a quality gate failing here is this intentional?

@michael-paystack
Copy link
Member Author

Yup @ali-paystack we're a little less concerned about test coverage right now (That sounds awful, I know).
We really just want to get this update out and then move on to rebuilding this.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

63.4% 63.4% Coverage
0.0% 0.0% Duplication

@michael-paystack michael-paystack merged commit 241f0e8 into master Feb 8, 2023
@ali-paystack
Copy link

@michael-paystack promise to do it next time 😄

@michael-paystack michael-paystack deleted the initialize-with-access-code branch February 8, 2023 09:50
@michael-paystack
Copy link
Member Author

Hand to the sky, I promise @ali-paystack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants