Skip to content

Commit

Permalink
Merge pull request #95 from PaystackHQ/fix/duplicate-resources
Browse files Browse the repository at this point in the history
Fix build issues due to conflict with Material Component attributes
  • Loading branch information
jubril-paystack authored Mar 25, 2020
2 parents 3ef495e + 1e77bac commit 689c4c8
Show file tree
Hide file tree
Showing 6 changed files with 21 additions and 20 deletions.
5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
[![Maven Central](https://maven-badges.herokuapp.com/maven-central/co.paystack.android/paystack-android/badge.svg)](https://maven-badges.herokuapp.com/maven-central/co.paystack.android/paystack-android)
[![API](https://img.shields.io/badge/API-16%2B-blue.svg?style=plastic)](https://android-arsenal.com/api?level=16)


Expand Down Expand Up @@ -36,8 +37,8 @@ You do not need to clone this repository or download the files. Just add the fol

```gradle
dependencies {
implementation 'co.paystack.android.design.widget:pinpad:1.0.2'
implementation 'co.paystack.android:paystack:3.0.14'
implementation 'co.paystack.android.design.widget:pinpad:1.0.4'
implementation 'co.paystack.android:paystack:3.0.17'
}
```

Expand Down
8 changes: 4 additions & 4 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ buildscript {
google()
}
dependencies {
classpath 'com.android.tools.build:gradle:3.4.0'
classpath 'com.android.tools.build:gradle:3.6.1'
classpath 'org.robolectric:robolectric-gradle-plugin:1.1.0'
classpath 'com.jfrog.bintray.gradle:gradle-bintray-plugin:1.7.3'
classpath 'com.github.dcendents:android-maven-gradle-plugin:1.5'
Expand All @@ -25,10 +25,10 @@ allprojects {
ext {
compileSdkVersion = 29
minSdkVersion = 16
targetSdkVersion = 25
versionCode = 24
targetSdkVersion = 29
versionCode = 26

buildToolsVersion = "29.0.2"
supportLibraryVersion = "28.0.0"
versionName = "3.0.14"
versionName = "3.0.17"
}
8 changes: 4 additions & 4 deletions example/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@ android {
}

dependencies {
api "com.android.support:appcompat-v7:$rootProject.ext.supportLibraryVersion"
api fileTree(include: ['*.jar'], dir: 'libs')
implementation "com.android.support:appcompat-v7:$rootProject.ext.supportLibraryVersion"
implementation fileTree(include: ['*.jar'], dir: 'libs')
testImplementation 'junit:junit:4.13-beta-2'
testImplementation 'org.assertj:assertj-core:3.12.2'
testImplementation 'org.robolectric:robolectric:4.3-alpha-2'
testImplementation 'org.mockito:mockito-core:1.10.19'
api project(':paystack')
// api "co.paystack.android:paystack:$rootProject.ext.versionName"
implementation project(':paystack')
// implementation "co.paystack.android:paystack:$rootProject.ext.versionName"
}
1 change: 1 addition & 0 deletions gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,4 @@
# This option should only be used with decoupled projects. More details, visit
# http://www.gradle.org/docs/current/userguide/multi_project_builds.html#sec:decoupled_projects
# org.gradle.parallel=true
android.useAndroidX=true
4 changes: 2 additions & 2 deletions gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#Wed May 08 19:25:39 WAT 2019
#Wed Mar 25 12:49:33 WAT 2020
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-5.1.1-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-5.6.4-all.zip
15 changes: 7 additions & 8 deletions paystack/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,13 @@ android {
}

dependencies {
api fileTree(dir: 'libs', include: ['*.jar'])
api 'com.google.code.gson:gson:2.8.5'
api 'com.squareup.retrofit2:retrofit:2.6.2'
api 'com.squareup.retrofit2:converter-gson:2.5.0'
api 'com.squareup.okhttp3:okhttp:3.14.6'
api "com.android.support:appcompat-v7:$rootProject.ext.supportLibraryVersion"

api 'co.paystack.android.design.widget:pinpad:1.0.2'
implementation fileTree(dir: 'libs', include: ['*.jar'])
implementation 'com.google.code.gson:gson:2.8.5'
implementation 'com.squareup.retrofit2:retrofit:2.6.2'
implementation 'com.squareup.retrofit2:converter-gson:2.5.0'
implementation 'com.squareup.okhttp3:okhttp:3.14.6'
implementation "com.android.support:appcompat-v7:$rootProject.ext.supportLibraryVersion"
implementation 'co.paystack.android.design.widget:pinpad:1.0.4'
}

ext {
Expand Down

0 comments on commit 689c4c8

Please sign in to comment.