Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the Day of the Week in your start-menu-clock makes things explode #2

Open
iriv24 opened this issue Aug 6, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@iriv24
Copy link
Collaborator

iriv24 commented Aug 6, 2024

Description

I am working off of 1.9, using the new fake RTC that was introduced. The relevant configurations are in include/config/overworld.h I used:
#define OW_TIMES_OF_DAY GEN_LATEST
#define OW_USE_FAKE_RTC TRUE
#define OW_ALTERED_TIME_RATIO GEN_LATEST

Then in start_menu.c, the relevant lines of code are:

StringExpandPlaceholders(gStringVar4, gDayNameStringsTable[(gLocalTime.days % 7)]);
//StringExpandPlaceholders(gStringVar4, gText_ContinueMenuTime); // prints "time" word, from version before weekday was added and leaving it here in case anyone would prefer to use it

if you leave the line uncommented the way it is there ^ so that the day is attempted to be printed, things will explode. as in, game crashes violently. If you comment the line out that is trying to print the day and just print the word "time", everything is happy.

Version

1.7.4 (Latest release)

Upcoming/master Version

im on 1.9

Discord contact info

iriv24

@iriv24 iriv24 added the bug Something isn't working label Aug 6, 2024
Pawkkie pushed a commit that referenced this issue Sep 30, 2024
Add logic to support cut master sidequest
Pawkkie pushed a commit that referenced this issue Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant