Fixed softlock w/ weather-triggered form changes & Cloud Nine (rh-hid…

…eout#4382) * Fixed softlock when weather-triggered form changes are suppressed by Cloud Nine * Removed KNOWN_FAILING; line from Castform Air Lock test
Pawkkie · May 16, 2024 · 8e7909c · 8e7909c
1 parent eb70d1c
commit 8e7909c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/battle_util.c b/src/battle_util.c
@@ -10566,7 +10566,8 @@ u16 GetBattleFormChangeTargetSpecies(u32 battler, u16 method)
                         targetSpecies = formChanges[i].targetSpecies;
                     }
                     // Otherwise, just check for a match between the weather and the form change table.
-                    else if (gBattleWeather & formChanges[i].param1
+                    // Added a check for whether the weather is in effect to prevent end-of-turn soft locks with Cloud Nine / Air Lock
+                    else if (((gBattleWeather & formChanges[i].param1) && WEATHER_HAS_EFFECT)
                         || (gBattleWeather == B_WEATHER_NONE && formChanges[i].param1 == B_WEATHER_NONE))
                     {
                         targetSpecies = formChanges[i].targetSpecies;

diff --git a/test/battle/ability/forecast.c b/test/battle/ability/forecast.c
@@ -266,7 +266,6 @@ SINGLE_BATTLE_TEST("Forecast transforms Castform back to normal when Sandstorm i
 
 SINGLE_BATTLE_TEST("Forecast transforms Castform back to normal under Air Lock")
 {
-    KNOWN_FAILING;
     GIVEN {
         PLAYER(SPECIES_CASTFORM_NORMAL) { Ability(ABILITY_FORECAST); }
         OPPONENT(SPECIES_WOBBUFFET);