Accept context when stopping updater#201
Open
myxzlpltk wants to merge 3 commits intoPaulSonOfLars:v2from
Open
Conversation
Owner
PaulSonOfLars
left a comment
PaulSonOfLars
left a comment
There was a problem hiding this comment.
Hi @myxzlpltk, thank you for the PR!
All of the methods in this lib have two versions; one without, and one with the context (suffixed with WithContext). This avoids us having to add breaking changes where they arent strictly necessary
Would it be possible for you to do the same thing for this PR, and add a StopWithContext method to support this? This will also have the advantage of fixing all the breaking tests that test the Stop() functionality :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes. Allow user to pass context when stop updater