Skip to content

[Draft] Add new message.CommandName filters#159

Closed
PaulSonOfLars wants to merge 1 commit intov2from
paul/commandname-msg-filter
Closed

[Draft] Add new message.CommandName filters#159
PaulSonOfLars wants to merge 1 commit intov2from
paul/commandname-msg-filter

Conversation

@PaulSonOfLars
Copy link
Copy Markdown
Owner

@PaulSonOfLars PaulSonOfLars commented May 9, 2024

What

This change adds a few new message filters to allow MessageHandlers to function similarly to CommandHandlers. With this new change, a CommandHandler can be considered a specialised MessageHandler (with command filters pre-applied).

Worth noting that with this change, the CommandHandler type becomes significantly less useful; maybe the type should be removed, and the NewCommand method should be left simply as a wrapper around NewMessage?

Impact

  • Are your changes backwards compatible? Yes; unless we choose to remove the CommandHandler type.
  • Have you included documentation, or updated existing documentation? Yes
  • Do errors and log messages provide enough context? Yes

@PaulSonOfLars PaulSonOfLars changed the title Add new message.CommandName filters [Draft] Add new message.CommandName filters May 18, 2024
@PaulSonOfLars
Copy link
Copy Markdown
Owner Author

Closing due to no interest from community

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant