[Draft] Add new message.CommandName filters#159
Closed
PaulSonOfLars wants to merge 1 commit intov2from
Closed
Conversation
…th command handlers.
Owner
Author
|
Closing due to no interest from community |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This change adds a few new message filters to allow
MessageHandlersto function similarly toCommandHandlers. With this new change, aCommandHandlercan be considered a specialisedMessageHandler(with command filters pre-applied).Worth noting that with this change, the
CommandHandlertype becomes significantly less useful; maybe the type should be removed, and the NewCommand method should be left simply as a wrapper around NewMessage?Impact