pat-modal: allow modal in modal #1010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO:
I'll rethink this whole thing |
…support modals in modals. Add configuration parameter for ``source`` and ``target``. This allows to reuse an existing #pat-modal instance and to open modals in modals.
|
This is an unobtrusive change and allows to open modals in modals immediately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Add new option
targetfor pat-modal which is passed to pat-inject when the modal injects content. This allows you to open modals in modals by selecting the already existing parent modal as injection target:#pat-modal::element.Adding demo to show how to add a modal-in-modal.
The class close-panel should not be added on the child-modal link.
@cornae this is a draft solution for further discussion.
I don't think modal-in-modals were supported until now. My fist attempt fixing .close-panel to allow a child modal to be injected and instantiated while closing the parent modal failed, because the child modal is opened within the parent one. I cannot close the parent modal without loosing the child modal.
We could fix this if we would always open modal on the body root. But this is not the case yet.
However this approach outlined in this PR seems to work.
We might change the pattern option name
targetto your liking and I probably have to optimize the code a bit more (unregistering event handlers, etc.).