Add workaround for new warning #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasohlund
approved these changes
Aug 9, 2023
bording
force-pushed
the
generate-documentation-file-fix
branch
from
b96aef7 to
77ddff0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with the 7.0.400 .NET SDK, there is a new warning:
For reasons detailed in the still open issue, getting IDE005 properly reported requires
GenerateDocumentationFile.Turning that on globally is a rather large pain at this point, and would have some weird interactions with some Particular.Packaging features.
Also, that linked issue is still open, so it's unclear if the requirement might actually change in the future.
I've instead opted to suppress the warning, and we can consider more changes later.