Consistently expose PublisherMetadata in NServiceBus.AcceptanceTests.Sources #7258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure Service Bus (#7257) * Extend publisher metadata * Tweak first acceptance test * Allow enforcing publisher metadata * Enforce publisher metadata to be present for all shipped tests * Enforce subscription metadata to be present * Better exception messages * Switch to the safer API * Moved tests that belong into the core folder * Change to HashSet because an endpoint can have different local addresses * Fix all tests (fingers crossed) * Put checks into extension * Learning transport runs native pub sub tests so we need to enforce the checks there too * Hopefully fix the tests * Fix last failing test * Use the correct data type --------- Co-authored-by: danielmarbach <[email protected]>
ramonsmits
reviewed
Jan 9, 2025
src/NServiceBus.AcceptanceTesting/Support/EnforceSubscriptionPublisherMetadataBehavior.cs
Show resolved
Hide resolved
ramonsmits
approved these changes
Jan 9, 2025
danielmarbach
changed the title
danielmarbach
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a purely internal change that makes sure
PublisherMetadatais always available in all shipped source acceptance tests. Only users that directly use NServiceBus.AcceptanceTests.Sources and NServiceBus.AcceptanceTesting benefit from updating to this patch version. All other users can safely skip this version.Brings back the following to release-9.2:
Contains a cherry-pick of the typo changes in:
Documentation
None