AssemblyScanner doesn't scan message assemblies that reference Message Interfaces #7091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e Interfaces (#7081) * Add a test to verify the messages referencing core are scanned * Failing test for messages that reference message interfaces * Unify in one test due avoid assembly loading issues * Cleanup * AssemblyScanner should scan assemblies that reference the message interfaces assembly to make sure messages using those interfaces can be discovered and do not act like unobtrusive messages * Extract into method with a huge comment and inline hints * Add a type forwarding test as a safety net * Update src/NServiceBus.Core.Tests/AssemblyScanner/When_using_type_forwarding.cs Co-authored-by: Phil Bastian <[email protected]> * Apply suggestions from code review Co-authored-by: Brandon Ording <[email protected]> * string.Equals Co-authored-by: Brandon Ording <[email protected]> --------- Co-authored-by: danielmarbach <[email protected]> Co-authored-by: Phil Bastian <[email protected]> Co-authored-by: Brandon Ording <[email protected]> (cherry picked from commit 3a7c74c)
PhilBastian
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #7081 which fixes #7092 for the
release-8.2branch