Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Roll out AIGeneratedDiscussion to all users #9554

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

tianrunhe
Copy link
Contributor

@tianrunhe tianrunhe commented Mar 20, 2024

Description

Fixes #8730

Testing scenarios

  • Paid Team

    • Select a paid team
    • Run a retro meeting
    • See the AI generated discussion prompt in the discussion phase
    • In the meeting summary page, see discussion question for each topics instead of topic summary
  • Free Trials

    • Create a new org/team
    • Run a retro meeting
    • See the AI generated discussion prompt in the discussion phase, with the free trial message
    • In the meeting summary page, see discussion question for each topics instead of topic summary

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@tianrunhe tianrunhe changed the title Roll out AIGeneratedDiscussion to all users chore: Roll out AIGeneratedDiscussion to all users Mar 20, 2024
@tianrunhe tianrunhe added the Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved label Mar 20, 2024
@tianrunhe tianrunhe marked this pull request as ready for review March 20, 2024 22:03
Copy link
Contributor

@nickoferrall nickoferrall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works for me!

We still have the AI Summary in the discussion thread too, so there's both the AI Summary & Discussion Prompt, which is too much text IMO, but I think we can remove the AI Summary in a follow-up PR.

@tianrunhe
Copy link
Contributor Author

Tested and it works for me!

We still have the AI Summary in the discussion thread too, so there's both the AI Summary & Discussion Prompt, which is too much text IMO, but I think we can remove the AI Summary in a follow-up PR.

Yes I plan to get to that later in a separate PR

@tianrunhe tianrunhe merged commit b8fa708 into master Mar 25, 2024
10 checks passed
@tianrunhe tianrunhe deleted the feat/rolloutAIDiscussion branch March 25, 2024 21:31
@github-actions github-actions bot mentioned this pull request Mar 27, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/s Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AI discussion prompts rolled out
2 participants