Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix Prettier configuration and reformat #317

Merged
merged 3 commits into from
Mar 8, 2024

Conversation

zlataovce
Copy link
Member

If you run the format script through yarn right now, you'll find yourself with a whole bunch of changes, even breaking documentation in some places; this PR aims to fix that.

Seems like Prettier does not support MDX v2 nor v3 yet, so I chose to ignore all Markdown and MDX files for the time being.

/.vscode
/.yarn
/build
/node_modules
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why we are including node_modules?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier automatically looks inside .gitignore, so it's redundant to ignore it there as well

Copy link
Member

@MiniDigger MiniDigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@olijeffers0n olijeffers0n merged commit 8110eb2 into PaperMC:main Mar 8, 2024
2 checks passed
@zlataovce zlataovce deleted the fix/prettier branch March 8, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants