Add vault change state event #12069
Open
Add vault change state event #12069
+181
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11679
Adds an event for when a vault block changes its state, allowing plugins to get and/or modify the resulting vault state (though doing something like forcefully setting the vault state to ACTIVE will cause the event to be thrown every second if there's no player nearby).
I'm not completely sure about having a getPlayer, because it requires us to pass the player instance through the unlock method and may not be completely accurate for the case where the vault becomes active. Without it, the diff would be less complex but the event would also be less useful.