Add methods for Armadillo #12031
Add methods for Armadillo #12031
Conversation
|
You don't need to specify implicit modifier (public) in interface. Same for your previous PRs. |
paper-server/src/main/java/org/bukkit/craftbukkit/entity/CraftArmadillo.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Nassim Jahnke <[email protected]>
paper-server/src/main/java/org/bukkit/craftbukkit/entity/CraftArmadillo.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @Override | ||
| public void rollUp() { |
There was a problem hiding this comment.
I'm not sure if it's intended but those methods should probably set/reset the DANGER_DETECTED_RECENTLY memory module type otherwise the changes are immediately reverted. Alternatively the key could be exposed in the api ig.
There was a problem hiding this comment.
I would argue re/setting the memory and and also exposing the memory key to API would be a good call
There was a problem hiding this comment.
yeah i forget about that checks.. i set the value (based in the damage call) and call erase for the roll methods for handle that, also expose the memory key for allow modify this.
There was a problem hiding this comment.
currently rollUp looks like working but the rollOut not.. when call rollOut and rollUp again not sure what behaviour im missing for that.
or just maybe document the conditions for roll
There was a problem hiding this comment.
I think you need to tweaks a bit more its brain.
The issue is that rollOut is called at the very end of the animation, if you want to keep the animation you would need to adjust the ttl to the duration of the unrolling animation.
There was a problem hiding this comment.
yeah but the animation are not a client side thing?
about the brain im a little lost for what touch i try things but still have the issue with rollOut roll out but the Armadillo rollUp again
There was a problem hiding this comment.
iirc armadillos have "state ticks" which tell the server to roll out again immediately if not defined properly
Resolve #12026 by adding methods to the State of the Armadillo and expose the roll behaviours in the API.