-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EntityHarvestBlockEvent #11951
base: main
Are you sure you want to change the base?
Add EntityHarvestBlockEvent #11951
Conversation
paper-api/src/main/java/org/bukkit/event/player/PlayerHarvestBlockEvent.java
Outdated
Show resolved
Hide resolved
paper-api/src/main/java/org/bukkit/event/entity/EntityHarvestBlockEvent.java
Outdated
Show resolved
Hide resolved
paper-api/src/main/java/org/bukkit/event/entity/EntityHarvestBlockEvent.java
Outdated
Show resolved
Hide resolved
paper-server/src/main/java/org/bukkit/craftbukkit/event/CraftEventFactory.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The case of foxes harvesting a sweet berry bush is currently missing, can be added in the FoxEatBerriesGoal#pickSweetBerries method
paper-api/src/main/java/io/papermc/paper/event/entity/EntityHarvestBlockEvent.java
Show resolved
Hide resolved
ready i try to handle the whole logic where the "first" (with first i mean the first of the stack) item its used for the "hand" of the fox and the rest for drop/pop. |
This starts in discord where the Composter when drop a bone meal not has any event... the first thing was use the Drop or Dispenser event but that not handle correctly in this behaviour... then Machine Maker suggest a new event.
Then this PR add a new event for the case when a Entity harvest a block currently for Vines and Composter. this new event cannot be a base of the player side by the original design... then add in the docs the mention for this cases...