Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torpedo produces thrust above water #710

Closed
meltingSnowdrift opened this issue Jun 21, 2019 · 1 comment
Closed

Torpedo produces thrust above water #710

meltingSnowdrift opened this issue Jun 21, 2019 · 1 comment

Comments

@meltingSnowdrift
Copy link

ISSUE TYPE
  • Bug Report (Something is broken)
KSP and BDA Version
KSP 1.7.2
BDA 1.3.1
OS / ENVIRONMENT

Windows 10

SUMMARY

This is related to #459 , which appears to not have been thoroughly fixed. Torpedoes do not stop producing thrust when they leave the water, causing them to fly into the sky. A torpedo can leave the water in many situations, even when fired from underwater or into the water at another object in the water. For example, a torpedo fired into the water in a direction close to the opposite of the direction to the target may try to seek the target by turning upward through the air.

A simple approach to fixing this is to simply prevent torpedoes from producing thrust when not immersed in water. If this is done, a torpedo trying to go into the air will lose thrust and fall when it leaves the water.

The fact that this problem is noticeable also illustrates problems with current torpedo behaviour: real torpedoes do not try to fly out of the water at all in most of the cases that cause this bug. That, however, is an entirely different issue of greater difficulty and less urgency.

STEPS TO REPRODUCE

There is no specific reproduction procedure needed. This problem occurs whenever a torpedo leaves the water and enters the air. Try launching a torpedo upward from underwater. Also try launching a torpedo into the water from a ship where the torpedo starts out facing exactly away from the target.

SuicidalInsanity added a commit to SuicidalInsanity/BDArmory that referenced this issue Sep 30, 2019
Torps now only activate underwater, and will produce no thrust/FX should they breach the surface and become aerial.
jrodrigv added a commit that referenced this issue Oct 22, 2019
@jrodrigv
Copy link
Collaborator

jrodrigv commented Nov 7, 2019

This will be fixed on next release by @SuicidalInsanity

@jrodrigv jrodrigv closed this as completed Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants