Removed compiler specific directives #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GCC directives are not documented inside clang so it seems that they would not work. A warning is thrown with #pragma warn in order to advise the user.
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to get closer to a working linux port (issue #66)
Removed compiler specific directives like
__debugbreak()and__declspecin order to be more portable. Other systems like GNU/Linux don't support those intrinsics, so they need to be replaced.Checking if
__GNUC__is defined we can detect if gcc is being usedStatus of PR:
__declspecwith GNU/Linux directives.__pragma(optimize)with GNU/Linux directives__pragma(warning)with GNU/Linux directivesGCC and CLANG seem to work differently as to what MSVC does, as they mostly work by pushing the current state, changing the state for a brief period, and then changing it back to what it was. This should not be a problem as I've seen the pattern
DISABLE_WHATEVERdo thingsENABLE_WHATEVERin the engine, but is something to think about in the future.