Return default from hash client (pinterest#352)

Pankrat · Oct 5, 2021 · a88fdb2 · a88fdb2
1 parent 07b5ecc
commit a88fdb2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/pymemcache/client/hash.py b/pymemcache/client/hash.py
@@ -358,7 +358,8 @@ def set(self, key, *args, **kwargs):
         return self._run_cmd('set', key, False, *args, **kwargs)
 
     def get(self, key, *args, **kwargs):
-        return self._run_cmd('get', key, None, *args, **kwargs)
+        default = kwargs.get('default', None)
+        return self._run_cmd('get', key, default, *args, **kwargs)
 
     def incr(self, key, *args, **kwargs):
         return self._run_cmd('incr', key, False, *args, **kwargs)

diff --git a/pymemcache/test/test_client_hash.py b/pymemcache/test/test_client_hash.py
@@ -257,6 +257,8 @@ def test_no_servers_left_with_commands_return_default_value(self):
 
         result = client.get('foo')
         assert result is None
+        result = client.get('foo', default='default')
+        assert result == 'default'
         result = client.set('foo', 'bar')
         assert result is False